add environment variables for Otel #42
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenTelemetry (OTel) environment variables for enhanced observability configuration and makes improvements to async handling in demo endpoints. The changes focus on standardizing telemetry configuration and fixing blocking operations in async functions.
- Adds standardized OTel environment variables for service identification and sampling configuration
- Replaces blocking
time.sleep()calls with proper asyncasyncio.sleep()in demo endpoints - Enables live metrics in Azure Monitor configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .env.template | Adds OTel environment variables for service configuration and Azure Application Insights connection |
| template_fastapi/app.py | Enables live metrics in Azure Monitor configuration |
| template_fastapi/routers/demos.py | Converts blocking sleep operations to async and adds additional processing simulation |
template_fastapi/routers/demos.py
Outdated
| await asyncio.sleep(sleep_ms / 1000.0) # Convert milliseconds to seconds | ||
| with tracer.start_as_current_span("child"): | ||
| logger.debug("Child span execution") | ||
| await asyncio.sleep(sleep_ms / 1000.0) # Simulate additional processing |
There was a problem hiding this comment.
Adding another sleep operation in the child span doubles the total execution time unexpectedly. This changes the API behavior significantly - callers expecting a sleep duration of X milliseconds will now experience 2X milliseconds. Consider removing this additional sleep or making it configurable.
Copilot uses AI. Check for mistakes.
ks6088ts
force-pushed
the
feature/issue-37_otel
branch
from
25d6a05 to
042cc3d
Compare
What this PR does / why we need it
Which issue(s) this PR fixes:
Fixes #37
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Additional Information